Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468570 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #4 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-11-07 12:51:16 EDT --- * Some general issues on your scriptlets: - First of all, generally rpm * should not treat any files/directories which are not listed in any rpms. * if rpm creates some files when the rpm is to be installed, all files must be listed in the rpm itself So: ------------------------------------------------- %pre tempdir=%{_datadir}/%{name}/installation-log mkdir -p $tempdir ------------------------------------------------- - If this directory is needed, then this directory _must_ be listed in %files list ------------------------------------------------- cp -r --remove-destination %{_sysconfdir}/{%name} %{_datadir}/%{name}/webmin-etc-conf-backup ------------------------------------------------- - (well first of all {%name} is wrong) - Treating %_sysconfdir/%name is wrong because this is not listed in any rpms. rpm should handle files only listed in some rpms. If if this webmin fails if some files exist under %_sysconfdir/%name, then %pre script should simply "exit with 1" and do backup of files under %_sysconfdir/%name must be done directly by sysadmin. ------------------------------------------------- %post ./setup.sh >$tempdir/webmin-setup.out 2>&1 chmod 600 $tempdir/webmin-setup.out ------------------------------------------------- - First of all, in this case $tempdir/webmin-setup.out (and the directory $tempdir itself) must be in %files list - And %attr must be used for this file - And please explain what ./setup.sh does (especially explain what files this setup.sh creates/modifies). Those files must all be listed in %files, too - Also "rpm -V webmin" must not fail with this (i.e. rpm stores the information of the size and md5sum values of the installed files. If this script modifies files listed in %files, then %verify(not size md5 mtime) should be used, for example) ------------------------------------------------- cat >%{_sysconfdir}/%{name}/uninstall.sh <<EOFF ------------------------------------------------- - Again, %_sysconfdir/%name{,uninstall.sh} must be %files list (i.e. this script must be packaged in webmin binary rpm from the beginning instead of being created here) ------------------------------------------------- %preun %{_libexecdir}/%{name}/run-uninstalls.pl ------------------------------------------------- - Also here, please explain what rub-uninstalls.pl does (especially what files this script modifies/deletes/etc) Again all files modified by this script must be in %files list. If it is impossible to list files in %files of this rpm, then calling setup.sh or run-uninstalls.pl must be done by sysadmins by themselves manually and must not be done by this rpm automatically. * Emply %clean ------------------------------------------------ %clean rm -rf %{buildroot} ------------------------------------------------ - must exist. * pre-compiled binaries - Please remove pre-compiled files to make it sure that all files are created from FOSS files such as ------------------------------------------------ *.class *.o *.jar *.dll * pre-compiled executable ------------------------------------------------ at %prep -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review