Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464054 Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |orcanbahri@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |orcanbahri@xxxxxxxxx Flag| |fedora-review? --- Comment #2 from Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> 2008-11-06 17:04:57 EDT --- * This package has licensing issues. The COPYING file is GPLv2+. Also the following files claim GPLv2+: depcomp missing QPulseAudioDeviceModel.hpp The file ConfigFile.h has a copy of MIT license, Modern Style with sublicense: http://fedoraproject.org/wiki/Licensing/MIT#Modern_Style_with_sublicense The file qprojectM-pulseaudio.cpp claims LGPLv2+ which causes the problem. This file links to libprojectM-qt, which is licensed as GPLv2+. But according to http://fedoraproject.org/wiki/Licensing#GPLCompatibilityMatrix (the bottom matrix) you can't release a project under LGPLv2+ if you link to a library that is licensed under GPLv2+. This project has to be converted to GPLv2+. According to the footnote 7 under the matrix, you are allowed to do that. Then the License tag in the SPEC should be License: GPLv2+ and MIT But please confirm this with the upstream. * According to the recent changes in the guidelines, for the new packages, you shouldn't have the --vendor tag in the desktop-file-install. * Why do you have two .desktop files? They look pretty much the same to me. One should be removed. * I'm not sure if you need Requires: libprojectM = %{version}, pulseaudio I will check this (you should check this too). Also I will finish the review sometime tonight or tomorrow. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review