Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467958 --- Comment #4 from Christopher D. Stover <quantumburnz@xxxxxxxxxxx> 2008-11-04 17:05:14 EDT --- Thanks for your thorough initial review Hans! I feel bad you found so much wrong the first time around, but I've made the fixes. Here's the new output from rpmlint: [Chris@localhost SPECS]$ rpmlint barry.spec barry.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 10, tab: line 4) 0 packages and 1 specfiles checked; 0 errors, 1 warnings. [Chris@localhost SPECS]$ rpmlint ../SRPMS/barry-0.14-1.fc10.src.rpm barry.src: W: mixed-use-of-spaces-and-tabs (spaces: line 10, tab: line 4) 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [Chris@localhost SPECS]$ rpmlint ../RPMS/i386/barry-* barry.i386: W: devel-file-in-non-devel-package /usr/lib/libbarry.so barry-devel.i386: W: spurious-executable-perm /usr/share/doc/barry-devel-0.14/www/static.sh barry-devel.i386: W: spurious-executable-perm /usr/share/doc/barry-devel-0.14/www/clean.sh barry-devel.i386: W: doc-file-dependency /usr/share/doc/barry-devel-0.14/www/clean.sh R barry-devel.i386: W: doc-file-dependency /usr/share/doc/barry-devel-0.14/www/static.sh R 4 packages and 0 specfiles checked; 0 errors, 5 warnings. I'm ignoring the library warning because it's not a devel file, it's required for the utilities to work. I'm also ignoring the doc file warnings because the shell scripts do need to be executable, and they generate/remove html devel documentation if the user runs them. In regards to your comments: * I'm not sure what happened with my source tarball. I redownloaded it so please let me know if it still appears to be different this time. * The .desktop file is in the SRPM this time. * I got rid of the libs and util package and consolidated them into the main package. Since the libraries are built from source and the libs package was required to do anything useful, I figured it made sense. Let me know if there's a problem with this. Also, I chose to consolidate the util package instead of gui because I see the util as more basic things to make the Blackberry work with Linux. Thanks again for your input and let me know what you think this time around. SPEC URL: http://8uxodw.bay.livefilestore.com/y1pX2QxGel80n1v0PasG0m-xSKp6YpCGEeOWnmN8rtAMELCATbd7GLcbMgylxarFMM3hKLHXhHWlPpXmnFciqdCDQ/barry.spec?download SRPM URL: http://8uxodw.bay.livefilestore.com/y1pX2QxGel80n1RK93qW0QkHr7q7HjnLMWS-65DxnUq66tI0412d2ruZCsj0cJJdqE0A-qGmzzCnw9Hmp1MYT-5tA/barry-0.14-1.fc10.src.rpm?download -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review