Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=171993 --- Comment #86 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2008-11-03 06:03:48 EDT --- (In reply to comment #85) > (In reply to comment #84) > > On another note, the spec should be modified to use mpi-selector in RHEL and > > environment-modules in Fedora so that users can easily select which environment > > to use. Alternatives is system-wide, and should not be used. > > > For one, mpi-selector in not in Fedora. And I've included support for using > environment-modules in the package since a long time ago. I prefer using > alternatives on my workstation, so I don't think support for that should be > removed. Well, I was referring to mpi-selector in EPEL. You're not interested in EPEL? Also, you're not requiring the environment-modules package in Fedora. > > Deji, are you still interested on working on the package? > srpm and rpm spec files for the latest release are available below; > ftp://czar.eas.yorku.ca/pub/mpich2/mpich2-1.0.8-1.fc10.src.rpm > ftp://czar.eas.yorku.ca/pub/mpich2/mpich2.spec OK. Could you add some comments on the BRs? To me BR emacs-common and gdb are a bit odd.. According to GCC man page, -fPIC only makes a difference on the m68k, PowerPC and SPARC (compared to -fpic?). Thus, should you have -fPIC also on ppc architectures? Why don't you have --enable-f77 in the configure phase? Since the package has Java functionality, you must follow the Java Packaging guidelines: MUST have: BuildRequires: java-devel [>= specific_version] BuildRequires: jpackage-utils Requires: java >= specific_version Requires: jpackage-utils Also, in the setup phase, clean out old .jar files: find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \; Otherwise the spec file seems quite clean to me. This is really an embarrassment, having had the package on review for 3 years. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review