Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469052 --- Comment #2 from Jeroen van Meeuwen <kanarip@xxxxxxxxxxx> 2008-11-02 19:27:38 EDT --- (In reply to comment #1) > 1 - please fix macros. > > replace > %{_sysconfdir}/init.d/ > with > %{_initrddir} > Fixed. > 2 - improve scriptlets > > https://fedoraproject.org/wiki/Packaging/Guidelines#Running_scriptlets_only_in_certain_situations > > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets > Fixed. > also when a more experienced user look your spec, he will ask to use install -p > to preserve timestamps :-) Fixed. New SPEC: http://www.kanarip.com/custom/SPECS/ris-linux.spec New SRPM: http://www.kanarip.com/custom/f9/SRPMS/ris-linux-0.4-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review