Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469492 --- Comment #1 from Lubomir Rintel <lkundrak@xxxxx> 2008-11-02 12:54:02 EDT --- The package seems pretty clean and well done -- thanks! However, there are some (mostly cosmetic) issues: 1.) Fix the version number Version: 0.0.0.for.teeworlds.0.4.3 # bam is not versioned Please don't make up version numbers like this. Using "0.4.3" as a version number would perfectly do. 2.) Use the original source code from upstream. Source0: http://cassmodiah.fedorapeople.org/%{name}-%{version}/SOURCES/%{name}-%{version}.tar.bz2 If you extracted this from a tarball with a public URL, use that one. If you checked it from a SCM, add a comment (and adjust the Release tag to the date you checked it out). 3.) Please improve Summary and description a bit: Summary: A fast and flexible build system Package Guidelines read: "Please put personal preferences aside..." while "fast and flexible" seem much like a personal preference. %description the bam build system for teeworlds Please use capitalization and punctuation correctly. Please consider enhancing the description a bit, so even a non-tech user understand what does the package do (and that he doesn't want to install it :). "A tool that controls process of producing executables of software from its source code. Used to build Teeworlds game." or something similar might be appropriate. 4.) Don't install bam into sbin install -D -m 0755 src/%{name} \ %{buildroot}%{_sbindir}/%{name} According to FHS sbin is intended for system administration tools, mainly used by root user. BAM is not used for administration and definitely shouldn't be run by root. 5.) Possibly do not include TODO sh todo.sh > TODO The produced file doesn't really make sense to anyone. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review