Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468797 --- Comment #1 from Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> 2008-11-02 11:50:05 EDT --- Full review, relevant items only. MUST Items: - MUST: rpmlint must be run on every package. The output should be posted in the review. $ rpmlint /var/lib/mock//fedora-rawhide-i386/result 2 packages and 0 specfiles checked; 0 errors, 0 warnings. - MUST: The package must meet the Packaging Guidelines . Summary: JRosetta provides a common base for graphical component No need to repeat package name in Summary. Suggestion: Summary: A common base for graphical user interface components ln -fs ${j}-%{version}.jar $RPM_BUILD_ROOT%{_javadir}/${j}.jar Why does it need the symlinks? All patches should have an upstream bug link or comment, so please add a comment before Patch0: jrosetta-1.0.1-rm_classpath.patch - MUST: The License field in the package spec file must match the actual license. Licence is GPLv2 only, not v2+. Please correct. - MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. Source matches upstream: 0f42365004065d01923bd55ca458fb47 jrosetta-1.0.1-GPL.zip Please add a comment in the specfile with either the URL of the download page or the full URL of the zip archive, i.e.: # http://dev.artenum.com/projects/JRosetta/download/JRosetta-1-0-1/data/src-gpl?action=download&nodecorator - MUST: The package must successfully compile and build into binary rpms on at least one supported architecture. Builds fine in mock for rawhide(F-10)/i386 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review