Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461929 --- Comment #5 from Nicolas Chauvet (kwizart) <kwizart@xxxxxxxxx> 2008-10-31 14:12:43 EDT --- koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=913629 You are building a noarch python package. Using CFLAGS is irrelevant. (it is replaced as -O2 only as noarch package). In the install section, why do you need to install twice ? %{__python} setup.py install -O1 --skip-build --root %{buildroot} should be enought. (at least there is the same set of files with this method). Gnome HIG recommends to use verb(s) in comments for desktop files... http://developer.gnome.org/projects/gup/hig/1.0/ About r1, it is annoying. But I think you have handled it right. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review