[Bug 462535] Review Request: python-foolscap - Next-generation RPC protocol, intended to replace Perspective Broker

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462535


David Carter <dcarter@xxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcarter@xxxxxxxxxxxxxxxx




--- Comment #1 from David Carter <dcarter@xxxxxxxxxxxxxxxx>  2008-10-30 18:46:27 EDT ---
This is a sample review only, as I'm not currently sponsored.

$ rpmlint -i python-foolscap-0.3.1-1.fc10.src.rpm 
python-foolscap.src: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line
18)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint -i python-foolscap-0.3.1-1.fc10.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

I don't think the mixed format should prohibit a release, but it should be
fixed before any subsequent releases.

Package meets name guidelines, as does the .spec file.

Spec file Changelog is OK.

License is OK, build fine on both i386 and x86_64.

Nice and simple :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]