Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464047 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mtasaka@xxxxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #9 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-10-30 16:20:40 EDT --- Well, as this is NEEDSPONSOR ticket and from Orcan's request (Orcan, thanks for your pre-remark) ! License - Well, this can be ignored for now but actually Parser.cpp looks like under GPLv2+ because of copy and paste mistake (perhaps...) Please ask upstream to fix the license clause on this file. * About Patch1 (perhaps CRLF issue) - Well, such "huge" patch is not desired (here I say "huge" because this patch changes the whole of the text file). This patch gives us the impression that you changed the whole of upstream ChangeLog by your some intention. For this case please use "sed" instead of creating patch to aviod creating such huge patch and to show that you actually used sed to fix CRLF issue and did not do anything. * cmake build log - For cmake please use --------------------------------------------------------- make %{?_smp_mflags} VERBOSE=1 --------------------------------------------------------- to make build.log more verbose (so that we can check if Fedora specific compilation flags are correctly honored, for example). * pkgconfig .pc file - libprojectM.pc.in contains --------------------------------------------------------- 1 prefix=@CMAKE_INSTALL_PREFIX@ 2 exec_prefix=@CMAKE_INSTALL_PREFIX@ 3 libdir=@CMAKE_INSTALL_PREFIX@/lib --------------------------------------------------------- It looks that libdir is expanded as /usr/lib even on 64 bits architecture so this is perhaps wrong. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review