Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225798 Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |orcanbahri@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |orcanbahri@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> 2008-10-30 14:48:57 EDT --- I reviewed this package. The following issues need to be addressed for compilance with the guidelines: * The files AUTHORS, ChangeLog, COPYING, HACKING, NEWS, README, TERMINOLOGY need to be listed under %doc * The package owns %dir %{_datadir}/gimp %dir %{_datadir}/gimp/%{gimpsubver} which are also owned by gimp. Note that the package Requires: gimp. The above ownerships need to be dropped. * %defattr(-,root,root,-) is preferred. * BuildRequires: libxml2 is not required since BuildRequires: libxslt will pull that up * Similarly BuildRequires: docbook-style-xsl is not required. It will be pulled up by other dependencies. Am I wrong? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review