Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463217 Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |orcanbahri@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |orcanbahri@xxxxxxxxx Flag| |fedora-review? --- Comment #9 from Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> 2008-10-28 23:05:14 EDT --- Package is in good condition. My notes: * Source0 must be given in full URL. * I would include the test.py and demo.py inside the %doc files, because they give a nice demonstration about how gnuplot-py should be used. You don't need to remove shebangs from them. Just do: mv %{buildroot}%{python_sitelib}/Gnuplot/demo.py doc/Gnuplot/ mv %{buildroot}%{python_sitelib}/Gnuplot/test.py doc/Gnuplot/ in the %install section. Or maybe you may want to install them inside an "examples" directory under %doc. Otherwise the package is good to go. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review