Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459878 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(mtasaka@xxxxxxxxx | |okyo.ac.jp) | --- Comment #15 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-10-28 10:59:29 EDT --- Well, from very quick glance: * Using /var/www is not allowed on Fedora https://fedoraproject.org/wiki/Packaging/Guidelines#Web_Applications * License tag should be "GPLv2+" Note that only putting GPLv2 license text does not mean that the license is under GPLv2: http://fedoraproject.org/wiki/Licensing/FAQ * Usually dependencies between main package and subpackages must be EVR (Epoch-Version-Release) specific (ref: https://fedoraproject.org/wiki/Packaging/ReviewGuidelines "MUST: In the vast majority of cases, devel packages..." This mentions only main <-> -devel packages, however this should usually be applied to any binary rpms generated from the same srpm) * Virtual Provides must usually be EVR specific (Vitual Provides without EVR information caused upgrading path problem many times...) * "Requires: genome" is redundant when "Requires: gnome-lib" is present (currently, however see below) * I guess that the dependency between genome and genome-lib is opposite * You have to write "BuildArch: noarch" only on the main package (and don't have to write on each subpackages) * Use "BuildRequires: rubygem(rake)", not rubygem-rake. c.f. https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides - By the way "BuildRequires: rubygem" is redundant when "BuildRequires: rubygem(rake)" is present. * When using "cp" or "install" commands, add "-p" option to keep timestamps on installed files: https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps * The scripts related to SysVinit script are wrong at several points. Also some Requires(preun) or so are missing. Please refer to: https://fedoraproject.org/wiki/Packaging/SysVInitScripts#Initscripts_in_spec_file_scriptlets https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Syntax * Please make it sure that directories which are created when installing a package are correctly owned by the package. There are some directories which are not owned by any packages or when the package is installed: https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership https://fedoraproject.org/wiki/Packaging/UnownedDirectories * We recommend %defattr(-,root,root,-) Also on some subpackages %defattr is completely missing (please use rpmlint to detect this type of packagins error) * Files under %_datadir/doc are automatically marked as %doc * %_sysconfdir/init.d must be %_initrddir https://fedoraproject.org/wiki/Packaging/SysVInitScripts#Initscripts_on_the_filesystem * /var must be %_localstatedir or so: https://fedoraproject.org/wiki/Packaging/RPMMacros * Please use macros consistently. For example at one place %{_bindir} is used (this is no problem because %{_bindir} is expanded as /usr/bin) where at other place /%{_bindir} (i.e. //usr/bin) is used. I just glanced at your spec file quickly and examined license issue and have not checked the details of this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review