Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458440 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #2 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2008-10-28 06:30:34 EDT --- (In reply to comment #0) > rpmlint reports 9 errors: "script-without-shebang", should I patch to correct > these errors ? (these shebang aren't needed at all) You can remove the shebang in the spec file or make a patch whatever you like. https://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Remove_shebang_from_files Just some quick comments on your spec file. Macros - You are using a lot of macros. IMHO, you should consider to drop them. Your spec file will be more readable. Even you miss one ( %{appdir}/locale/bluemindo.pot -> podir?) ;-) BuildRequires: - Python packages should be sure to have: BuildRequires: python https://fedoraproject.org/wiki/Packaging/Python %build section - What is %{nil}? Source0: http://www.codingteam.net/upload/77133a-bluemindo-0.2.1.tar.gz - You can switch to 'Source0: http://www.codingteam.net/upload/77133a-%{name}-%{version}.tar.gz' this way you haven't to take care of this after a new release of the source. %files - You can add all %doc entries on one line %doc AUTHORS CHANGELOG... but that only cosmetical %changelog - for correct changelog entries, take a look at https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review