Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468633 --- Comment #7 from manuel wolfshant <wolfy@xxxxxxxxxxxxxxxxxx> 2008-10-27 17:57:58 EDT --- > The first patch is 'Patch0' Just for the record: that's more a cosmetic / pedantic problem. rpm is very happy to use anything, as long as the definition of the patch (the PatchN line) and it's usage (the %PatchN line) correspond. But yes, for a first submission looking nice (from a cosmetic point of view) is important and could be a decision factor. More important: please preserve the older changelog entries when you/add make changes and create new releases of the spec. I am looking at releases 2 and 3 right now and I would have liked to know what was changed compared to the first ones. Especially as the _current_ changelog (the one from release 3) still says "Initial package." A correct changelog would have probably had something along: * Thu Oct 27 2008 Itamar Reis Peixoto <itamar@xxxxxxxxxxxxxxxx> - 0.6.1-3 - start counting patches from 0 * Thu Oct 27 2008 Itamar Reis Peixoto <itamar@xxxxxxxxxxxxxxxx> - 0.6.1-2 - fixes %%files, consistent use of macros<, other relevant changes, if any> * Thu Oct 26 2008 Itamar Reis Peixoto <itamar@xxxxxxxxxxxxxxxx> - 0.6.1-1.0 - Initial package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review