Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468633 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #1 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2008-10-27 10:07:32 EDT --- Just some small comments on your spec file - Release: 1.0%{?dist} - Just '1' is enough. Next release will be '2' - You can use the macro %{name} everywhere where you used 'wput' - %files section - '%defattr(-,root,root)', the usual one is '%defattr(-,root,root,-)' https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#.25files_section - Is it not enough just to use '%{_bindir}/%{name}' insteed of '%attr(0755, root, root) %{_bindir}/wput' ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review