[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468631


Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx




--- Comment #1 from Ralf Corsepius <rc040203@xxxxxxxxxx>  2008-10-26 22:17:01 EDT ---
Just a couple of remarks:

(In reply to comment #0)
> [rpm@laptop024 i386]$ rpmlint libgarmin*
> 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Interesting, rpmlint is worse than I had thought:)

MUSTFIX
- libgarmin.a is missing from *-devel
Without, this *-devel rpm is widely useless.

- package doesn't support shared libraries
=> Must add *-static magic to *-devel

- Wrong License:
Your spec says: License:        GPLv2+
Several files (e.g. libgarmin.h and COPYING) inside of the sources say:
 GPLv2 *only*.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]