Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468517 --- Comment #4 from Lubomir Rintel <lkundrak@xxxxx> 2008-10-26 14:20:06 EDT --- Thanks for the comments Mamoru! (In reply to comment #2) > Created an attachment (id=321519) --> (https://bugzilla.redhat.com/attachment.cgi?id=321519) [details] > Comment for Patch2 Good catch. Will fix. > Some notes for 1.35.1-1: > > * License > - Well as far as I checked the whole code I only find codes > under > * license written in "COPYING" (Copyright only) > * LGPLv2+ (e.g. fitsfile.c) > So the license tag should be "LGPLv2+". > Also add some files to %doc which indicates LGPL license. Thanks, you seem to be right. Will be fixed in next revision. > * Source origin > - Would you write where you obtained %SOURCE3? I stole it :) Actually -- the logo is present in the source code (being the default picture to display). I grabbed this one from some random site and converted from gif, assuming it's no problem to use it given it's already included in the source code anyways. > * BuildRequires > - In your srpm "BuildRequires: desktop-file-utils" is missing > (while the spec file on the URL you posted here has it) I must have uploaded some older version by mistake. I will ensure it is present in next revision. > * %install script > - What is the line below for? > ------------------------------------------------------------- > install -d $RPM_BUILD_ROOT/dev Will remove it. It was used in on of earlier revisions, since the make install creates some links in /dev by default. > * XML file > - I guess this should be installed under %_datadir/mime/packages Right. Thanks for noticing that. > * Directory ownership issue > - The directory %_datadir/mime must not be owned by this > package. Why? It does not include shared-mime-info or any other package that would require it in its dependency chain. > By the way: > open error: No such file or directory > ERROR: unable to open /dev/imt1o > Error: No remote input possible. This is OK since we do not ship IRAF. > Program received signal SIGSEGV, Segmentation fault. This does not happen in my el5. Could you please tell me which Fedora version do you use? Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review