[Bug 435015] Review Request: gpp4 - LGPL CCP4 library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=435015


Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |mtasaka@xxxxxxxxxxxxxxxxxxx
            Summary|Review Request: libGPP4 -   |Review Request: gpp4 - LGPL
                   |LGPL CCP4 library           |CCP4 library
              Alias|libGPP4                     |gpp4
               Flag|                            |fedora-review?




--- Comment #16 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx>  2008-10-26 11:48:42 EDT ---
Some notes

? License
  - License tag can be okay with LGPLv2 as README file
    declares so, however all files under src/ directories
    are actually under LGPLv2+.
    Would you ask upstream about this? (as it is okay
    with LGPLv2, this is not a blocker)

* Source tarball
  - The tarball in the srpm differs from what I could
    download from the URL written as %SOURCE
------------------------------------------------------
514623 2008-06-10 05:21 gpp4-1.0.4-9.fc10.src/gpp4-1.0.4.tar.gz
498933 2007-09-03 00:00 orig/gpp4-1.0.4.tar.gz

48931781425a5b79a8255ebefaed24b3  orig/gpp4-1.0.4.tar.gz
7494566588545eb167b1c4c6e486cdf4  gpp4-1.0.4-9.fc10.src/gpp4-1.0.4.tar.gz
------------------------------------------------------

* Linkage error
  - rpmlint shows
------------------------------------------------------
gpp4.i386: W: undefined-non-weak-symbol /usr/lib/libgpp4.so.0.0.0 sincos
gpp4.i386: W: undefined-non-weak-symbol /usr/lib/libgpp4.so.0.0.0 sqrt
gpp4.i386: W: undefined-non-weak-symbol /usr/lib/libgpp4.so.0.0.0 rintf
gpp4.i386: W: undefined-non-weak-symbol /usr/lib/libgpp4.so.0.0.0 lrint
------------------------------------------------------
    For packages providing -devel subpackage these rpmlint warnings
    cannot be allowed because these will cause linkage error when
    using these libraries.
    I guess linking to libm.so (-lm) will remove these warnings.

    Note:
    You can use rpmlint also for installed rpms like:
    $ rpmlint gpp4
    which will show you these warnings.

* Duplicate documents
  - Generally there is no need to include a document file as %doc
    to both main and -devel packages.

* Timestamps
------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT install='install -p'
------------------------------------------------------
  - This should be "INSTALL='install -p'".

? Another rpmlint issue
------------------------------------------------------
gpp4-devel.i386: W: file-not-utf8
/usr/share/doc/gpp4-devel-1.0.4/doc/latex/csym_f_page.tex
------------------------------------------------------
  - Well it may be preferable to convert this file to UTF-8,
    however I am not sure if tex supports UTF-8 tex file
    (at least it is well-known that platex does not support
     Japanese UTF-8 tex files...)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]