Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468554 --- Comment #2 from Simon Wesp <cassmodiah@xxxxxxxxxxxxxxxxx> 2008-10-26 06:47:20 EDT --- Some Issues missing DesktopFile usage (https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage) Remove unusualy Categories in the desktopfile install like (http://standards.freedesktop.org/menu-spec/latest/apa.html) desktop-file-install \ --remove-category="X-Red-Hat-Base;Application" \ --delete-original \ --dir=%{buildroot}%{_datadir}/applications \ $RPM_BUILD_ROOT/%{_datadir}/applications/%name.desktop echo Icon=barrage >> barrage.desktop use macros, because it looks better: echo Icon=%{name} >> %{name}.desktop in my opinion it is better to write a little patch to correct the categories and the missing icon of this desktopfile and just validate the desktopfile install. It's easier to handle and minimize and clear the spec-file. desktop-file-validate $RPM_BUILD_ROOT/%{_datadir}/applications/%{name}.desktop Icons: look at comment 1 %files: you wrote: %dir %{_datadir}/%{name} %{_datadir}/%{name}/* I would rather write: %{_datadir}/%{name}/ %doc AUTHORS ChangeLog COPYING INSTALL README %doc AUTHORS BUGS ChangeLog COPYING INSTALL README -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review