Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466974 --- Comment #3 from Ville Skyttä <ville.skytta@xxxxxx> 2008-10-25 14:27:29 EDT --- I don't know the upstream status of the patches. The only one of them that contains any fuzz is the "constness" patch which is pretty much cosmetic and can in principle be dropped if the fuzz makes people nervous. Others just have some line offsets. Note that even if the F-10 rpmbuild rejects fuzz by default, packagers can override that on will for the whole package or selectively on per patch basis. The way the patching is currently set up is least work for me and least work when tracking/verifying patch origin, and I've verified that despite the line offsets and bit of fuzz in one patch, they do the right thing and I'm committed to verifying that in future as well. Due to the way Debian patchkits are organized, if one wants to use them, not everything can be done with %patch. The initial patchkit can be applied with that, but it contains other patches inside it for which the only option is to use plain "patch". If recreating the patches from scratch and thus disconnecting them from their origin is a requirement for this package to pass review, I'll do it, but I don't see any real benefits in doing so, just some more work. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review