Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466974 Ville-Pekka Vainio <vpivaini@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vpivaini@xxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |vpivaini@xxxxxxxxxxxxxx --- Comment #2 from Ville-Pekka Vainio <vpivaini@xxxxxxxxxxxxxx> 2008-10-25 13:34:25 EDT --- I'll take the review, it'll be my first review, though, but this isn't that different from any of the VDR plugins already in Fedora. I've only taken a quick look at this now, I'll need to spend some time going through all the guidelines a bit later. I'm not quite happy with how the patches are handled now. You take the "combined" Debian patch and then use patch "manually" instead of using %patch. In Fedora 10 %patch doesn't allow any fuzz, but with your current solution the patches in debian/ need fuzz and they are still applied. It'd be better if you separated the needed patches from the debian patchset and applied those with %patchN. The patches would also need to be modified to not need any fuzz. Do you know what's the upstream status of these patches? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review