Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #2 from Chitlesh GOORAH <cgoorah@xxxxxxxxxxxx> 2008-10-25 12:36:18 EDT --- #001: Release: 2%{?dist} This requires that first - first, for the version 3.680, this is the first src.rpm, thus your Release should be 1 and not 2. . Release: 1%{?dist} - second, every changelog entry should entail the version-release tag Here is how your changelog should be: * Thu Oct 16 2008 Lane Brooks <lane [AT] brooks DOT nu> - 3.680-1 - Initial package based on SUSE packages from Guenter Dannoritzer <dannoritzer{%}web{*}de> For more info : https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs You have noticed that I have set your email address to: "lane [AT] brooks DOT nu". This is to limit unwanted spam to your email address. #002: Licensing: With Fedora's strict packaging policies, all spec files should entail the exact license and its version. In your case it will be: License: GPLv2 For more info: https://fedoraproject.org/wiki/Licensing #003: Replace tabs with spaces Line 6 in your spec file : Group: Applications/Engineering #004: This line should be removed, as your name is already listed in the changelogs Packager: Lane Brooks <lane@xxxxxxxxx> #005: Referencing the SourceX: All the SourceX: tag should have their complete urls: For more info: https://fedoraproject.org/wiki/Packaging/SourceURL #006: Remove Autoreqprov: On #007: Build requires Exceptions In accordance to https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions, you can safely remove the following buildrequires: BuildRequires: gcc, gcc-c++ #008: Add a "-q" to the following: %setup -n %{name}-%{version} #009: Use macros as much as you can in your spec file: /usr/share/ --> %{_datadir} ./configure --> %configure /usr --> %{_prefix} cp -> %{__cp} rm -> %{__rm} for more info: https://fedoraproject.org/wiki/Packaging/RPMMacros #010: Keep timestamps use -p with %{__cp} such as %{__cp} -pr Please take some time reading the fedora packaging guidelines again and update the actual spec file. Everytime you update and publish a new spec file, don't forget to increment the Release tag and update the changelog. Once you have updated the above issues, I will dig in-depth about verilator's compilation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review