Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466496 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #1 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2008-10-24 04:49:11 EDT --- Just some small comments on your spec file. %define name python-suds %define version 0.3.1 %define release 1 Name: %{name} Version: %{version} Release: %{release} - You duplicate the content, the following line will be enough. Name: python-suds Version: 0.3.1 Release: 11%{?dist} Source0: %{name}-%{version}.tar.gz - The source should come from upstream. I guess something like the line below will work, but I'm not sure Source0: https://fedorahosted.org/suds/attachment/wiki/WikiStart/%{name}-%{version}.tar.gz?format=raw https://fedoraproject.org/wiki/Packaging/SourceURL %description - There is no need for a space in front of every line, but is only cosmetically %install and %files - You shouldn't rely on INSTALLED_FILES, as that will not list directories, which will need to be specified in the %files section as well. Using globs in the %files section is safer. https://fedoraproject.org/wiki/Packaging/Python#System_Architecture %changelog - The word 'release' is not nessesary, just ...com> - 0.3.1-1 There is no need for a space in front of every line https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs Details about Python modules: https://fedoraproject.org/wiki/Packaging/Python -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review