Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 --- Comment #16 from Peter Robinson <pbrobinson@xxxxxxxxx> 2008-10-21 06:38:30 EDT --- > - according to guidelines, "--vendor=fedora" should be used for > desktop-file-install Actually according to the packaging guidelines the Vendor should only be set if there isn't one already in use. They already use 'gupnp' https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files > - the %files section could be written with just 3 lines: > %{_datadir}/gupnp-tools > %{_bindir}/gupnp* > %{_datadir}/applications/*.desktop Yes, I'm aware of that but the reason I tend to do it the other way is that you don't get unexpected files that may be introduced on a new release. Its one of those 6 to one, hlaf a dozen to the other things. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review