Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466655 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2008-10-20 22:56:53 EDT --- Looks good; %check section is present and passes; generically-named binary and headers have been renamed or moved into their own directory. The only minor thing I can point out is that it looks perhaps a bit odd to have fplll_micro and fplll_verbose, but fplll-generate (underscores versus a dash). It's minor, so feel free to import what you like but of course it would be tough to change after import. If there are basic things not mentioned in the packaging guidelines, please feel free to point them out so that the packaging committee can address them. Unfortunately the review-o-matic isn't going to be able to catch anything more than trivial issues, and you could get the same just by doing scratch builds and running rpmlint on the result. Anyway, this package looks fine to me. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review