Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225681 Patrice Dumas <pertusus@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx --- Comment #10 from Patrice Dumas <pertusus@xxxxxxx> 2008-10-17 14:07:42 EDT --- (In reply to comment #9) > desktop-file-utils is already in cvs. this review is just a post core merge review. What does this exactly means? This package hasn't been reviewed already, it may not meet the criteria for inclusion in fedora. * does desktop-mime-type.prov really belong to that package? Looks like it should better be in redhat-rpm-config. * there are emacs guidelines http://fedoraproject.org/wiki/Packaging/Emacs * the following comment is strange, certainly a leftover: # https://bugs.freedesktop.org/show_bug.cgi?id=12018 * please don't mention GNOME and KDE in description, better use freedesktop or the like. All the window manager in fedora I know about use the .desktop files to create their menu. * Is there a reason why %_smp_mflag isn't used? * the source archive timestamp isn't kept, it is too late now, but please keep it next time -rw-rw-r-- 1 dumas dumas 348871 Feb 11 2008 desktop-file-utils-0.15.tar.gz -rw-rw-r-- 1 dumas dumas 348871 Mar 4 2008 desktop-file-utils-0.15.tar.gz-old * source match upstream 2fe8ebe222fc33cd4a959415495b7eed desktop-file-utils-0.15.tar.gz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review