Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464117 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |464141 --- Comment #5 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2008-10-15 21:16:08 EDT --- This failed to build for me; all of the tests failed due to a lack of Test::More. It is quite important that you test your builds in mock or do a koji scratch build before submitting them. To do that, install fedora-packager and then either run mock -r fedora-rawhide-i386 --rebuild perl-SVN-Notify-2.78-1.fc9.src.rpm (which may take quite some time to download packages if you don't have a fast connection) or run fedora-packager-setup to get your keys set up and then run koji build --scratch dist-f10 perl-SVN-Notify-2.78-1.fc9.src.rpm to build the package in our buildsystem on what will soon become F10. After adding BuildRequires: perl(Test::More), things build OK. However, I guess this requires Text::Trac in order to install, even though nothing in this ticket indicates that. I'll set up the proper dependencies, although I wish that had been done ahead of time so that I wouldn't have wasted the time reviewing this. A couple of other comments: It looks a little odd to not enclose "_bindir" (after %files -n svnnotify) in brackets, but I don't think it makes any difference. Otherwise there are minor deviations from our usual Perl packages (which are mostly autogenerated) but nothing material. The descriptions are a bit sparse. I guess the one for the Perl module comes from upstream, but the one for the svnnotify package doesn't seem to actually indicate with the package does. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review