Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463233 David Lutterkort <lutter@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #2 from David Lutterkort <lutter@xxxxxxxxxx> 2008-10-15 15:49:34 EDT --- OK - Package name OK - License info is accurate OK - License tag is correct and licenses are approved OK - License files are installed as %doc OK - Specfile name OK - Specfile is legible OK - No prebuilt binaries included OK - BuildRoot value (one of the recommended values) OK - PreReq not used OK - Source md5sum matches upstream FIX - No hardcoded pathnames mentions /etc/pam.d, use %_sysconfdir OK - Package owns all the files it installs OK - 'Requires' create needed unowned directories OK - Package builds successfully on i386 and x86_64 (mock) OK - BuildRequires sufficient OK - File permissions set properly OK - Macro usage is consistent FIX - rpmlint is silent NIT - lots of tabs lead to goofy indentation; remove tabs I get the following from rpmlint: ace-console-wui.noarch: E: zero-length /usr/share/ace/ace-console-wui/db/development.sqlite3 ace-console-wui.noarch: W: symlink-should-be-relative /usr/share/ace/ace-console-wui/config/environments/production.rb /etc/ace-console-wui/production.rb ace-console-wui.noarch: W: symlink-should-be-relative /usr/share/ace/ace-console-wui/config/environments/test.rb /etc/ace-console-wui/test.rb ace-console-wui.noarch: W: symlink-should-be-relative /usr/share/ace/ace-console-wui/config/database.yml /etc/ace-console-wui/database.yml ace-console-wui.noarch: W: symlink-should-be-relative /usr/share/ace/ace-console-wui/config/environments/development.rb /etc/ace-console-wui/development.rb ace-console-wui.noarch: W: dangling-symlink /usr/share/ace/ace-console-wui/tmp /var/lib/%{inst_name}/tmp ace-console-wui.noarch: W: symlink-should-be-relative /usr/share/ace/ace-console-wui/tmp /var/lib/%{inst_name}/tmp ace-console-wui.noarch: E: incoherent-subsys /etc/rc.d/init.d/ace-console-wui ace-console-wui} Either fix them or explain why they are ok to keep. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review