Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445537 --- Comment #10 from Adam Tkac <atkac@xxxxxxxxxx> 2008-10-15 08:13:48 EDT --- (In reply to comment #9) > formal review is here, see the notes below: > > BAD package meets naming and versioning guidelines. Fixed > BAD compiler flags are appropriate. Fixed, -O0 was (and probably will be during early F11 cycle) temporary option because it makes core dumps more usable. > BAD scriptlets present Fixed > - rpmlint complains: > tightvnc-debuginfo.x86_64: W: spurious-executable-perm > /usr/src/debug/tightvnc-1.5.0-svn2975/unix/xserver/*/*.[ch] (about 12 files) > run "chmod a-x unix/xserver/*/*.[ch]" after copying the xorg-x11-server-Xorg > sources into the tightvnc tree Fixed > > - the EVR in Obsoletes/Provides must be greater than the EVR of the package we > are replacing (use EVR=4.1.2-36, no dist tag) - see > https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Renaming.2Freplacing_existing_packages Fixed > > - server subpackage should have "Requires: xorg-x11-server-Xorg" for the > ownership of %{_libdir}/xorg/modules/extensions/ dependency on xorg-x11-server-Xorg doesn't seem so good for me so I moved libvnc.so module to server-module subpackage which requires xorg-x11-server-Xorg > - remove the X-Red-Hat-Extra from the desktop file Removed Updated sources: http://people.redhat.com/atkac/tightvnc.spec http://people.redhat.com/atkac/tightvnc-1.5.0-0.5.20081015svn3019.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review