Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452387 Jon Ciesla <limb@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |limb@xxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |limb@xxxxxxxxxxxx Flag| |fedora-review? --- Comment #9 from Jon Ciesla <limb@xxxxxxxxxxxx> 2008-10-14 15:50:03 EDT --- rpmlint clean. Drop the explicit ncurses Requires, rpm will do it automatically. Despite being a console app, this could benefit from a .desktop file, see bombardier. netblox -R mentions the Forbidden Proper Noun. Probably should be patched to be more general, but it's your call, as Spot did indeed lift the Legal flag. Spot is still free to correct me on this, however. Mock build fails. Patch #7 (netris-0.52-pysiak1.diff): + /bin/cat /builddir/build/SOURCES/netris-0.52-pysiak1.diff + /usr/bin/patch -s -p1 --fuzz=0 4 out of 6 hunks FAILED -- saving rejects to file game.c.rej 1 out of 1 hunk FAILED -- saving rejects to file inet.c.rej RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.rqp5dT (%prep) Bad exit status from /var/tmp/rpm-tmp.rqp5dT (%prep) Child returncode was: 1 EXCEPTION: Command failed. See logs for output. # ['bash', '--login', '-c', 'rpmbuild -bb --target i386 --nodeps builddir/build/SPECS/netblox.spec'] Traceback (most recent call last): File "/usr/lib/python2.5/site-packages/mock/trace_decorator.py", line 70, in trace result = func(*args, **kw) File "/usr/lib/python2.5/site-packages/mock/util.py", line 316, in do raise mock.exception.Error, ("Command failed. See logs for output.\n # %s" % (command,), child.returncode) Error: Command failed. See logs for output. # ['bash', '--login', '-c', 'rpmbuild -bb --target i386 --nodeps builddir/build/SPECS/netblox.spec'] LEAVE do --> EXCEPTION RAISED You should either re-diff the patch, or put this at the beginning of the spec as a temporary workaround: %define _default_patch_fuzz 2 Honestly, re-diffing would be better. Once fixed, mock builds are fine, no BuildRequire issues. Other than the Requires and patch fuzz issue, there are really no blockers after a full review. Since I see you need a sponsor, please do a few practice reviews and post links here. Once that's done satisfactorily, I'd be willing to sponsor you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review