[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459979





--- Comment #14 from Nicolas Chauvet (kwizart) <kwizart@xxxxxxxxx>  2008-10-14 08:54:58 EDT ---
I have built mlt Fedora 8 x86_64 with --disable-qimage --disable-mmx and it
worked also for rawhide.(0) But in this last case, i also need to disable see
in %prep section:
----------
#disable sse unless x86_64
%ifnarch x86_64
sed -i.checksse -e 's|ifndef __DARWIN__|ifdef __DARWIN__|'
src/modules/motion_est/filter_motion_est.c
#Note that this conditional is wrong
%endif
--------------
I haven't checked that, but if mmx is used on ppc, then is will certainly
fails.
What i expect is mmx should be disabled in all cases unless i686:
%configure \
...
%ifnarch i686
 --disable-mmx \
%endif
So anyone that want to rebuild mlt with theses options can do so with using
--target=i686 for the package.

There is lot of modules that aren't built. jack-rack,  frei0r (1) and sox(2)
despite this last has been requested as BuildRequires; and there is also others
that cannot be in Fedora.
The main interest of mlt using modules is that you can add support for theses
module at install step. At the packaging level that would be interesting to
have mlt splitted into sub-packages , specially if dependencies are huges
(candidate are jack-rack and gtk ). 

About mlt-config, it is not multilibs compliant:
(see l.4: export libdir=/usr/lib64 on lib64 systems)
There are two workarounds, either hack the libdir value (if /usr/lib64 exist
then... else /usr/lib...), or rewrite it as a wrapper around pkg-config.
But It would be possible IMO to just delete it and patch the dependent
applications (if any ?) to use pkg-config for mlt detection.

(0) http://koji.fedoraproject.org/koji/taskinfo?taskID=879994
  ppc64 still has failed, might be because of asm conditionals, it should work
guess.
(1) see https://bugzilla.redhat.com/show_bug.cgi?id=456256
(2) see https://bugzilla.redhat.com/show_bug.cgi?id=226425

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]