Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466762 --- Comment #2 from Jon Ciesla <limb@xxxxxxxxxxxx> 2008-10-13 11:08:31 EDT --- rpmlint on srpm clean On rpms: ipmitool.i386: W: service-default-enabled /etc/rc.d/init.d/ipmievd The service is enabled by default after "chkconfig --add"; for security reasons, most services should not be. Use "-" as the default runlevel in the init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword to fix this if appropriate for this service. Is this really necessary? ipmitool.i386: W: incoherent-init-script-name ipmievd The init script name should be the same as the package name in lower case, or one with 'd' appended if it invokes a process by that name. Fixable, or does this coorespond with what's in openipmi-tools? I see no upstream future in the patch, but you might want to comment on that in the spec, just the same. Running a mock build to test BuildRequires, but otherwise, other than the above, it looks great on full review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review