Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=445537 --- Comment #8 from Adam Tkac <atkac@xxxxxxxxxx> 2008-10-13 04:06:01 EDT --- (In reply to comment #7) > few notes > - you can use "svn export" instead of "svn checkout" (or a even script like > http://fedora.danny.cz/fedora-getsvn), the source archive will be smaller, but > when you are using upstream released snapshots, use them good hint > - the EVRs in Obsoletes/Provides are inconsistent between main package and > -server subpackage and I don't think that the main package should contain > Obsol/Prov for vnc-server fixed > - better use --with-os-name="Fedora" in xserver's %configure (instead of > "Fedora 11") might be > - replace /etc with %{_sysconfdir}, /etc/rc.d/init.d with %{_initddir} in > %build and %install sections fixed > - don't add X-Red-Hat-Extra into desktop file, fix the file directly instead of > using command line options, use fedora as vendor, missing BR: > desktop-file-utils - more about desktop files at > https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files should be fixed as well. Updated srpm & spec: http://people.redhat.com/atkac/tightvnc.spec http://people.redhat.com/atkac/tightvnc-1.5.0-0.4.svn2975.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review