Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461575 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #6 from Parag AN(पराग) <panemade@xxxxxxxxx> 2008-10-13 03:12:31 EDT --- + is OK - is NEED work Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=876684 + rpmlint is silent for SRPM - rpmlint is NOT silent for RPM. openvas-libraries.i386: W: incoherent-version-in-changelog 1.0-2-2 1.0.2-2.fc10 ==> correct it at time of cvs import. + source files match upstream url 9113c17581ffec1b1c490896b63422f1 openvas-libraries-1.0.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package openvas-libraries-1.0.2-2.fc10 -> Provides: libopenvas.so.1 libopenvas_hg.so.1 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.2.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libgnutls.so.26 libgnutls.so.26(GNUTLS_1_4) libnsl.so.1 libopenvas.so.1 libopenvas_hg.so.1 libpcap.so.0.9 libresolv.so.2 libresolv.so.2(GLIBC_2.0) libresolv.so.2(GLIBC_2.2) libresolv.so.2(GLIBC_2.9) libutil.so.1 rtld(GNU_HASH) + Package openvas-libraries-devel-1.0.2-2.fc10 -> Requires: /bin/sh libopenvas.so.1 libopenvas_hg.so.1 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review