Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465758 manuel wolfshant <wolfy@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |wolfy@xxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #7 from manuel wolfshant <wolfy@xxxxxxxxxxxxxxxxxx> 2008-10-12 21:35:08 EDT --- Indeed, all tests worked locally and, according to the advices I have received via IRC, not running the tests during koji build is fine. I'll do a full review soon, but could you please consider wrapping the disabled tests in a conditional block, so that one could do a local build in the form rpmbuild --rebuild "with tests" perl-Net-Daemon ? It's not a blocker, but I think it is more elegant than blindly deleting them and it only takes very few additional lines in the spec. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review