[Bug 226212] Merge Review: OpenIPMI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226212


Ville Skyttä <ville.skytta@xxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |ville.skytta@xxxxxx
               Flag|                            |fedora-review?




--- Comment #1 from Ville Skyttä <ville.skytta@xxxxxx>  2008-10-12 15:48:20 EDT ---
Partial/initial review comments moved from bug 466343:

1) BuildRequires: tcl-devel would result in some TCL support built in.  Not
sure if it's desirable though, but would be good to explicitly enable/disable
it for reproducible builds.

2) A private copy of libedit is used; would be good to make use of the
separately packaged system libedit.

3) A GUI is included in the sources, but not installed.  Is this on purpose?

4) ipmitool seems to be capable of using freeipmi as well.  I haven't tried it
but I suppose "BuildRequires: freeipmi-devel" would build it in.  Same thing as
comment 1) about reproducible builds applies, but wouldn't it make sense to
split ipmitool into a completely separate package instead of bundling it in
here?

The Mandriva openipmi package seems to have a bunch of improvements over the
Fedora/EL one, such as TCL support, UI (whose separation allows fewer
dependencies in the main package, e.g. TCL) and GUI subpackages.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]