Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460838 Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |orcanbahri@xxxxxxxxx Flag| |fedora-review? --- Comment #9 from Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> 2008-10-11 19:03:50 EDT --- The package is in pretty good shape. I have a few requests: * Make the .desktop file richer. Begin the Name: and GenericName: parts with capital letters. GenericName should be something different then %{name}; it needs to be descriptive. Also afaik you should put a --remove-category="Application" flag to desktop-file-install (or remove that entry manually from %{SOURCE1}) Please check out these guidelines: http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files * If a package includes something as %doc, it must not affect the runtime of the application. When you click on the "Help" icon on the main window you get this error: help file not found: /usr/share/doc/printoxx/userguide-en.html This needs fixed. * Other than this I couldn't manage to print anything other than blank pages with this software. Does it work on you? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review