Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465372 --- Comment #7 from Patrice Dumas <pertusus@xxxxxxx> 2008-10-11 05:29:05 EDT --- I'd prefer if the chntpw-README.Fedora was also renamed. The main aim of not having 'Fedora' is to be reused, so it shouldn't be anywhere: https://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks The -p for keeping timestamps is notfor newly created executables, since their timestamp is the one of the build anyway, but for the files that may have their timestamps kept, here the man page and README file. Just a suggestion, staticaly compiled executable should be kept, they don't do harm (and could even be used in-source), even though they are not of use in fedora. I also suggest a comment in the spec file telling where the version comes from since the source archive has another version string. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review