Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455396 --- Comment #3 from Lucian Langa <cooly@xxxxxxxxxxxx> 2008-10-10 15:42:19 EDT --- (In reply to comment #1) > If you drop the %{builddir} it works. fixed > Also, you need to BuildRequire desktop-file-utils and expat-devel. fixed > Since upstream uses lowercase some places in their naming and uppercase in > others, from what I see, it might be better to make this package's name all > lowercase. Your call. lowered the name > Comment on status of your patches WRT upstream. If submitted upstream, > indicate this in the spec. If not, do so, and indicate in the spec. fixed > Add ChangeLog, INSTALL and the help/ dir to %doc. Added ChangeLog and help/*, INSTALL is only required for people that want to compile this from source. also add detection for zlib, expat on x86_64 arch (koji failed to build those) .. and bumped version to: http://lucilanga.fedorapeople.org/trustedqsl.spec http://lucilanga.fedorapeople.org/trustedqsl-1.11-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review