Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458338 --- Comment #7 from Pavel Alexeev <pahan@xxxxxxxxxxxxxxx> 2008-10-10 14:50:55 EDT --- (In reply to comment #6) > > (In reply to comment #5) > > (In reply to comment #4) > > > * Macros > > > > > - %distname is not defined. > > > > %distname replaced by %{distribution} > > > > > > - My system does not define %distribution macro. Koji seems to > > > define it, however its value (string) is "Unknown" so > > > this is still wrong. > > > Just use "--vendor=fedora". > > Hmmm. What about this > > http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Avoiding_using_fedora_or_redhat > > recommendation to opposite do NOT using names like Fedora o Redhat in spec??? > > - This item says that naming a document as "README.fedora" or so > should be avoided, This document says what this names should be compleatly avoided when possible. File name is just example. > however I oppose to it because there are many > Fedora specific packaging issue... So, if you oppose, I think you should discuss about it with FESCO... > Also this item says that "Of course this doesn't cover internal > details like spec file conditionals like %fedora or %rhel." > So please use --vendor=fedora. Conditionals is conditionals, it is exactly for that, so, failing "%if %fedora" or similar is not fatal in any case even more so if it will be non Fedora build... > ! Note > Currently not a few maintainers simply remove "--vendor=foo" > when using desktop-file-install. If you remove this completely > I don't oppose to it Ok, I do that. I think it is best way now. > * Category of desktop file > - As you create the base desktop file by yourself, you can simply > add > ------------------------------------------------ > Category=Video; > ------------------------------------------------ > line between "%{__cat} > %{name}.desktop << EOF" > and EOF lines, then remove "--add-category=Video" > ! Note > - Semicolon is needed at the last. Ok, I'm do how you say. Is there any differences where Category mentioned? And I tryed this, but got error: /var/tmp/DivFix++-0.30-3.fc9-root-pasha//usr/share/applications/DivFix++.desktop: error: file contains key "Category" in group "Desktop Entry", but keys extending the format should start with "X-" Error on file "DivFix++.desktop": Failed to validate the created desktop file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review