Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455396 Jon Ciesla <limb@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |limb@xxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |limb@xxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Jon Ciesla <limb@xxxxxxxxxxxx> 2008-10-10 11:35:57 EDT --- Build error: + mkdir -p /var/tmp/TrustedQSL-1.11-1.fc9-root-limb/usr/share/applications + mkdir -p /var/tmp/TrustedQSL-1.11-1.fc9-root-limb/usr/share/pixmaps + cp icons/key48.png /var/tmp/TrustedQSL-1.11-1.fc9-root-limb/usr/share/pixmaps/TrustedQSL.png + sed -i -e s/.png//g tqsl.desktop + sed -i -e s/.png//g tqslcert.desktop + desktop-file-install --vendor=fedora --dir=/var/tmp/TrustedQSL-1.11-1.fc9-root-limb/usr/share/applications /home/limb/rpmbuild/BUILD/tqsl.desktop Error on file "/home/limb/rpmbuild/BUILD/tqsl.desktop": No such file or directory error: Bad exit status from /var/tmp/rpm-tmp.32062 (%install) If you drop the %{builddir} it works. Also, you need to BuildRequire desktop-file-utils and expat-devel. rpmlint is clean on everything. Since upstream uses lowercase some places in their naming and uppercase in others, from what I see, it might be better to make this package's name all lowercase. Your call. Comment on status of your patches WRT upstream. If submitted upstream, indicate this in the spec. If not, do so, and indicate in the spec. Add ChangeLog, INSTALL and the help/ dir to %doc. Otherwise, full review looks good. I'm doing another mock build, I'll post back with any further BR issues. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review