Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465511 --- Comment #6 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-10-09 14:04:50 EDT --- Created an attachment (id=319888) --> (https://bugzilla.redhat.com/attachment.cgi?id=319888) License analysis Well, * About itext-no-rups.patch: - Would you explain what "it depends on proprietary com.sun classes" means? I am not familiar with Java, however as far as I checked quickly * About pdf-renderer.jar: Is it different from the below? https://pdf-renderer.dev.java.net/ https://pdf-renderer.dev.java.net/files/documents/6008/113009/PDFRenderer-2008_10_05-src.zip It is available under LGPLv2+ * About dom4j-1.6.1.jar Fedora has "dom4j" rpm, of which the license says BSD * License - My analysis attached. The license tag should be "(LGPLv2+ or MPLv1.1) and and ASL2.0 and BSD and MIT" ( + "+ LGPLv2+ and CC-BY" if you build rups part) * SourceURL - Please consider to use %version macro. With using this macro you probably won't have to change SourceURL when version is upgraded. https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D * Requires - bouncycastle-mail Requires bouncycastle so "Requires: bouncycastle" is not needed. * Provides - For upgrade path and so on, this type of Provides (Provides: iText) should be full EVR (Epoch-Version-Release) specific. * GCJ AOT - For (Build)Requires/Scriptlets, please follow: https://fedoraproject.org/wiki/Packaging/GCJGuidelines ! By the way -------------------------------------------------- %post -p %{_bindir}/rebuild-gcj-db -------------------------------------------------- cannot be used because this is a shell script. * %prep -------------------------------------------------- %prep %setup -c -T -n %{name}-%{version} gzip -dc %{SOURCE0} | tar xf - -------------------------------------------------- - can be: -------------------------------------------------- %prep %setup -q -c -T -a 0 -------------------------------------------------- * %defattr - We recommend %defattr(-,root,root,-) * -javadoc subpackage - As javadoc package is for documentation, there is no need to mark %{_javadocdir}/%{name}-%{version} as %doc explicitly. - For Requires of javadoc subpackage please follow %package javadoc section of https://fedoraproject.org/wiki/Packaging/Java#ant_2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review