Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458338 --- Comment #5 from Pavel Alexeev <pahan@xxxxxxxxxxxxxxx> 2008-10-09 12:45:42 EDT --- (In reply to comment #4) > Well, > > * SourceURL > - seems 404. The correct one is perhaps: > http://downloads.sourceforge.net/divfixpp/%{name}_v%{version}-src.tar.bz2 Ok, sorry. > - So what I am saying is that you must modify cflags what is used > on this tarball by default so that Fedora cflags are used correctly > (i.e. you must use %optflags manually). > Also this tarball uses "-Os" option, which should be removed. > > One of the solution is: > -------------------------------------------------------- > %prep > %setup -q -n %{name}_v%{version} > sed -i.flags -e 's|-Os||' makefile > ...... > ...... > %build > make %{?_smp_mflags} WXCONFIG=wx-config CPP="g++ %optflags" > ------------------------------------------------------- Oh, thank you. I'm put it into spec. > > * Macros > > > - %distname is not defined. > > %distname replaced by %{distribution} > > - My system does not define %distribution macro. Koji seems to > define it, however its value (string) is "Unknown" so > this is still wrong. > Just use "--vendor=fedora". Hmmm. What about this http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Avoiding_using_fedora_or_redhat recommendation to opposite do NOT using names like Fedora o Redhat in spec??? And lso in this dociment I get macros %{distribution}... > ! By the way if you put macros in braces please them consistently > for cosmetic issue (i.e. use %{__install}) Ok, I did that. BTW I like better %__install then %{__install}. http://hubbitus.net.ru/rpm/Fedora9/DivFix++/DivFix++-0.30-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review