Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463123 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #8 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-10-08 09:38:37 EDT --- Almost okay. * CFLAGS * Gconf schemas install -- Actually the reason this build didn't honor Fedora cflags is because of configure(.in) From configure.in: ----------------------------------------------------------- 119 if test "x$GCC" = "xyes"; then 120 CFLAGS="-Wall -Werror -g " 121 fi ----------------------------------------------------------- The line 120 is completely unneeded (the corresponding line on configure is around the lines 16745) For this package just modifying configure is sufficient. - build.log shows: ----------------------------------------------------------- 560 if test -z "/builddir/build/BUILDROOT/gnomint-0.5.4-1.fc10.i386" ; then \ 561 for p in gnomint.schemas ; do \ 562 GCONF_CONFIG_SOURCE=xml:merged:/etc/gconf/gconf.xml.defaults gconftool-2 --makefile-install-rule $p; \ 563 done \ 564 fi ----------------------------------------------------------- Calling gconf-2 during rpmbuild is not preferred (see: https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf ) Fortunately configure accepts --disable-schemas-install, which prevents gconf-2 call. So changing %build stage as below will solve these two issues: ----------------------------------------------------------- %build sed -i -e 's|CFLAGS="-Wall -Werror -g "|true|' configure %configure --disable-schemas-install make %{?_smp_mflags} ----------------------------------------------------------- * Scriptlets - For safety close the lines with || : even for update-desktop-database: https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database Other things are okay. ----------------------------------------------------------- This package (gnomint) is APPROVED by mtasaka ----------------------------------------------------------- As I wrote on another review request: Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join from "Install the Client Tools (Koji) ". I am already sponsoring you. If you want to import this package into Fedora 8/9, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system). If you have questions, please ask me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review