Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465740 Orcan Ogetbil <orcanbahri@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |orcanbahri@xxxxxxxxx Alias| |rubygem-gettext Flag| |fedora-review+ --- Comment #7 from Orcan Ogetbil <orcanbahri@xxxxxxxxx> 2008-10-07 16:28:41 EDT --- Thanks for the update! * I have one suggestion. The two rpmlint errors: rubygem-gettext-doc.noarch: E: zero-length /usr/share/doc/rubygem-gettext-doc-1.93.0/test/rails/public/favicon.ico rubygem-gettext-doc.noarch: E: zero-length /usr/share/doc/rubygem-gettext-doc-1.93.0/samples/rails/public/favicon.ico These are favicons (the icon (image) that shows in your browser to the left of the addressbar when you go to a webpage). These are probably for the .html doc files. Having them at zero-length is most likely a mistake of upstream. I would let them know. You can also create a favicon from their logo yourself (with gimp or imagemagick or so) and replace with the in the package. I leave this up to you. -------------------------------------------------------------------------- * One last thing I noticed. If I go to /usr/share/doc/rubygem-gettext-doc-1.93.0/samples/rails/public/ or /usr/share/doc/rubygem-gettext-doc-1.93.0/test/rails/public/ the index.html there has a broken link: "About your applications environment" points to some non-existing file:///usr/share/doc/rubygem-gettext-doc-1.93.0/{samples,test}/rails/public/rails/info/properties Did you forget to package something, or is this an upstream mistake again? -------------------------------------------------------------------------- But otherwise the package seems good. Check these issues and see if there's anything we can do. I'm now approving it. -------------------------------------------------- This package (rubygem-gettext) is APPROVED by oget -------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review