Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462250 --- Comment #7 from Tim Fenn <fenn@xxxxxxxxxxxx> 2008-10-06 14:53:41 EDT --- (In reply to comment #6) > For -3: > > * %version macro > - Please consider to use %{version} macro (also see: > https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D > I wasn't sure how best to apply this here, can you provide some more detail as to what you mean? > * CFLAGS in noarch rpm > - The part CFLAGS="$RPM_OPT_FLAGS" is not needed because > this is noarch. > Oops - fixed. > * Macros in %changelog or comments > - In %changelog or comments, use %% instead of % (e.g. > "add doc to %%files, add ..") so that macros won't be > expanded. > Done. spec url: http://www.stanford.edu/~fenn/packs/python-pmw.spec srpm url: http://www.stanford.edu/~fenn/packs/python-pmw-1.3.2-4.f8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review