Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457925 Orcan Ogetbil <orcanbahri@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |orcanbahri@xxxxxxxxx --- Comment #1 from Orcan Ogetbil <orcanbahri@xxxxxxxxx> 2008-10-05 02:53:23 EDT --- The package is in good condition. Some notes: ------------------------------------------------------------------------- The line: dos2unix Readme.txt LICENSE.txt is not necassary. You can use "sed" instead. See: http://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#wrong-file-end-of-line-encoding So you can remove dos2unix from BuildRequires ------------------------------------------------------------------------- $RPM_OPT_FLAGS is not passed to gcc correctly. Hence the debuginfo package is not useful. ------------------------------------------------------------------------- Please be consistent with macros. e.g. in the spec file there is cp -ra data/* %{buildroot}%{_datadir}/biniax/data in one line and %{_datadir}/%{name} on the other. ------------------------------------------------------------------------- It would be nice if you can make the desktop file richer. Please see: http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files At least, have those fields that are given in that example full. For instance "Name:Biniax" (mind the capital letter) would look nicer. ------------------------------------------------------------------------- Summary: An unique ... should be Summary: A unique ... ------------------------------------------------------------------------- The game does not exit properly. I have to kill the process in order to exit the game. Is this because of your patch? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review