[Bug 225900] Merge Review: initscripts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225900





--- Comment #3 from Bill Nottingham <notting@xxxxxxxxxx>  2008-09-30 14:14:02 EDT ---
(In reply to comment #2)
> initscripts.src:11: W: hardcoded-path-in-buildroot-tag

Fixed.

> initscripts.src:21: W: unversioned-explicit-obsoletes event-compat-sysv
> initscripts.src:39: W: unversioned-explicit-obsoletes rhsound
> initscripts.src:39: W: unversioned-explicit-obsoletes sapinit
> initscripts.src:40: W: unversioned-explicit-obsoletes hotplug

These are all things that are unconditionally dead as a doornail.

I suppose we could remove event-compat-sysv since it never shipped in a final
release, and rhsound and sapinit just becuase they are really really really
ancient things.

> initscripts.src:41: E: prereq-use /sbin/chkconfig, /usr/sbin/groupadd,
> /bin/sed, coreutils

Fixed.

> initscripts.src:252: E: files-attr-not-set
> initscripts.src:253: E: files-attr-not-set

I believe RPM does the right thing here in any case (otherwise the package
would not build.) But fixed.

> initscripts.src:623: W: macro-in-%changelog config
...

All fixed.

> initscripts.src: W: mixed-use-of-spaces-and-tabs (spaces: line 110, tab: line
> 955)

Fixed.

> initscripts.src: W: no-url-tag
> The URL tag is missing.
> 
> We need this.  Might be good to set something up on hosted for this purpose.

Something added. May or may not be useful.

More in a bit.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]