Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=451189 --- Comment #12 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-09-30 13:54:19 EDT --- For -0.4.a8: * CFLAGS ------------------------------------------------ export CFLAGS=$RPM_OPT_FLAGS ------------------------------------------------ - This line is not needed because %configure does this. (You can check what %configure does by $ rpm --eval %configure ) * Macros in comment ------------------------------------------------ #%{_sysconfdir}-files ------------------------------------------------ - Use %% in comments (and %changelog) instead of %% to prevent maros from being expanded. * Symlinks ------------------------------------------------ W: symlink-should-be-relative /usr/bin/rancid-cvs /usr/lib/rancid/rancid-cvs W: symlink-should-be-relative /usr/bin/rancid-run /usr/lib/rancid/rancid-run W: symlink-should-be-relative /usr/bin/rancid-fe /usr/lib/rancid/rancid-fe W: symlink-should-be-relative /usr/bin/rancid /usr/lib/rancid/rancid ------------------------------------------------ - It is requested that all symlinks should be relative (not absolute) i.e. ------------------------------------------------ for base in \ %{name} %{name}-cvs %{name}-fe %{name}-run do ln -sf ../../%{_libdir}/%{name}/${base} \ $RPM_BUILD_ROOT%{_bindir}/${base} done ------------------------------------------------ is better. Note that with the above lines you don't have to "push" to $RPM_BUILD_ROOT%{_bindir} . * About permission/directory ownership * %_sysconfdir/%name (In reply to comment #10) > Directory ownership: > %{_sysconfdir}/%{name}/ should be owned by this command > "%attr(750,%{name},%{name}) %config(noreplace) %{_sysconfdir}/%{name}/" ? - Perhaps you want: ------------------------------------------------- #%%{_sysconfdir}-files %attr(750,%{name},%{name}) %dir %{_sysconfdir}/%{name} %attr(600,%{name},%{name}) %config(noreplace) %{_sysconfdir}/%{name}/* ------------------------------------------------- * Directories in filesystem rpm ------------------------------------------------- %dir %{_bindir}/ %dir %{_mandir}/*/ ------------------------------------------------- - These directories are owned by filesystem rpm and so should not be owned by this rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review